ZihanLi58 commented on a change in pull request #3393:
URL: https://github.com/apache/gobblin/pull/3393#discussion_r719815800
##########
File path:
gobblin-cluster/src/test/java/org/apache/gobblin/cluster/HelixAssignedParticipantCheckTest.java
##########
@@ -50,16 +50,16 @@ public void setUp()
suite = new IntegrationBasicSuite(jobConfigOverrides);
helixConfig = suite.getManagerConfig();
- String clusterName =
helixConfig.getString(GobblinClusterConfigurationKeys.HELIX_CLUSTER_NAME_KEY);
- String zkConnectString =
helixConfig.getString(GobblinClusterConfigurationKeys.ZK_CONNECTION_STRING_KEY);
- helixManager = HelixManagerFactory.getZKHelixManager(clusterName,
"TestManager",
- InstanceType.SPECTATOR, zkConnectString);
}
@Test (groups = {"disabledOnCI"})
//Test disabled on Travis because cluster integration tests are generally
flaky on Travis.
public void testExecute() throws Exception {
suite.startCluster();
+ String clusterName =
helixConfig.getString(GobblinClusterConfigurationKeys.HELIX_CLUSTER_NAME_KEY);
Review comment:
Same as the comment above, it's after bump helix version, seems we have
to call suite.startCluster first before we get a new helix manager instance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
