autumnust commented on a change in pull request #3393: URL: https://github.com/apache/gobblin/pull/3393#discussion_r724582157
########## File path: gobblin-api/src/main/java/org/apache/gobblin/source/InfiniteSource.java ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.gobblin.source; + +import com.google.common.eventbus.EventBus; + +/** + * An interface for infinite source, where source should be able to detect the work unit change + * and post the change through eventBus + * + * @author kgoodhop Review comment: you don't want to give up your name lol ########## File path: gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-api/src/main/snapshot/org.apache.gobblin.service.flowexecutions.snapshot.json ########## @@ -282,6 +282,7 @@ } ], "finders" : [ { "name" : "latestFlowExecution", + "doc" : "Retrieve the most recent matching FlowExecution(s) of the identified FlowId", Review comment: relevant? ########## File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java ########## @@ -264,23 +266,25 @@ public static void setDefaultAuthenticator(Properties properties) { } /** - * Handle {@link WorkUnitChangeEvent}, by default it will donothing + * Handle {@link WorkUnitChangeEvent}, by default it will do nothing */ @Subscribe public void handleWorkUnitChangeEvent(WorkUnitChangeEvent workUnitChangeEvent) throws InvocationTargetException { LOG.info("start to handle workunit change event"); try { - this.removeTaskFromRunningHelixJob(workUnitChangeEvent.getOldTaskIds()); - this.addTaskToRunningHelixJob(workUnitChangeEvent.getNewWorkUnits()); + this.removeTasksFromHelixJob(workUnitChangeEvent.getOldTaskIds()); + this.addTasksToHelixJob(workUnitChangeEvent.getNewWorkUnits()); } catch (Exception e) { //todo: emit some event to indicate there is an error handling this event that may cause starvation throw new InvocationTargetException(e); } } - protected void removeTaskFromRunningHelixJob(List<String> taskIdsToRemove) throws IOException {} - protected void addTaskToRunningHelixJob(List<WorkUnit> workUnitsToAdd) throws IOException {} + protected void removeTasksFromHelixJob(List<String> taskIdsToRemove) throws IOException, ExecutionException, Review comment: logically, this shouldn't be named with something related helix right ? ########## File path: gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/WorkUnitChangeEvent.java ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.source.extractor.extract.kafka; Review comment: should it be sitting in a non-kafka specific module ? Or let's rename / add javadoc to make it clear that it is for kafka use cases only now ########## File path: gobblin-api/src/main/java/org/apache/gobblin/source/InfiniteSource.java ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.gobblin.source; + +import com.google.common.eventbus.EventBus; + +/** + * An interface for infinite source, where source should be able to detect the work unit change + * and post the change through eventBus + * + * @author kgoodhop + * + * @param <S> output schema type + * @param <D> output record type + */ +public interface InfiniteSource<S, D> extends Source<S, D>{ Review comment: You may want to put @alpha annotation here (since I believe there's be evolving in this interface -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
