[
https://issues.apache.org/jira/browse/GOBBLIN-1556?focusedWorklogId=660123&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-660123
]
ASF GitHub Bot logged work on GOBBLIN-1556:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Oct/21 06:01
Start Date: 05/Oct/21 06:01
Worklog Time Spent: 10m
Work Description: sv2000 commented on a change in pull request #3407:
URL: https://github.com/apache/gobblin/pull/3407#discussion_r721912670
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/FsJobConfigurationManager.java
##########
@@ -88,6 +88,12 @@ public void run() {
}, 0, this.refreshIntervalInSeconds, TimeUnit.SECONDS);
}
+ @Override
+ protected void shutDown() throws Exception {
Review comment:
Interesting. What happens in the absence of shutdown() method? It was a
little confusing from the PR description - if AM is stopped and the
JobConfigManager continues to check for job specs, does it mean that the AM is
prevented from exiting? Is there any impact on the Gobblin-on-Yarn application
because of this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 660123)
Time Spent: 1h (was: 50m)
> Add shutdown logic in FsJobConfigurationManager
> -----------------------------------------------
>
> Key: GOBBLIN-1556
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1556
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> We don't have shutdown logic in FsJobConfigurationManager, so when AM
> stopped, it still tries to fetch job status.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
