[
https://issues.apache.org/jira/browse/GOBBLIN-1556?focusedWorklogId=660421&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-660421
]
ASF GitHub Bot logged work on GOBBLIN-1556:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Oct/21 16:19
Start Date: 05/Oct/21 16:19
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on a change in pull request #3407:
URL: https://github.com/apache/gobblin/pull/3407#discussion_r722404558
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/FsJobConfigurationManager.java
##########
@@ -88,6 +88,12 @@ public void run() {
}, 0, this.refreshIntervalInSeconds, TimeUnit.SECONDS);
}
+ @Override
+ protected void shutDown() throws Exception {
Review comment:
No, it does not affect the exiting. It will stop after the whole
container is existed. Just in another issue where AM stuck after existing, I
notice this thread also not been exited, so make this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 660421)
Time Spent: 1h 10m (was: 1h)
> Add shutdown logic in FsJobConfigurationManager
> -----------------------------------------------
>
> Key: GOBBLIN-1556
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1556
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> We don't have shutdown logic in FsJobConfigurationManager, so when AM
> stopped, it still tries to fetch job status.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
