[
https://issues.apache.org/jira/browse/GOBBLIN-1585?focusedWorklogId=690342&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690342
]
ASF GitHub Bot logged work on GOBBLIN-1585:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/21 21:54
Start Date: 03/Dec/21 21:54
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on a change in pull request
#3439:
URL: https://github.com/apache/gobblin/pull/3439#discussion_r762308812
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java
##########
@@ -296,6 +296,14 @@ private static void
modifyStateIfRetryRequired(org.apache.gobblin.configuration.
mergedState.putAll(fallbackState.getProperties());
mergedState.putAll(state.getProperties());
+ // Set CURRENT_ATTEMPTS_FIELD to right value to avoid continually retrying
+ if
(fallbackState.getPropAsInt(TimingEvent.FlowEventConstants.CURRENT_ATTEMPTS_FIELD,0)
> state.getPropAsInt(TimingEvent.FlowEventConstants.CURRENT_ATTEMPTS_FIELD,0))
{
Review comment:
Why the default is 0, should not it be 1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 690342)
Time Spent: 20m (was: 10m)
> GaaS (DagManager) keep retrying a failed job beyond max attempt number
> ----------------------------------------------------------------------
>
> Key: GOBBLIN-1585
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1585
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The issue is that for the same flow execution, we don't receive the event in
> order. if the job fail and we retry, we may receive running event first, and
> then the Orchestrate event which update the current attempts and should retry
> value will be ignored and cause to job to continually try to retrying util
> the running job finished.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
