[
https://issues.apache.org/jira/browse/GOBBLIN-1585?focusedWorklogId=690370&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690370
]
ASF GitHub Bot logged work on GOBBLIN-1585:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/21 22:42
Start Date: 03/Dec/21 22:42
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on pull request #3439:
URL: https://github.com/apache/gobblin/pull/3439#issuecomment-985890863
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3439?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3439](https://codecov.io/gh/apache/gobblin/pull/3439?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(50c1da1) into
[master](https://codecov.io/gh/apache/gobblin/commit/a7df7ca45d5281d2a0b831fb305fb0131aa4adac?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(a7df7ca) will **decrease** coverage by `3.17%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/gobblin/pull/3439?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3439 +/- ##
============================================
- Coverage 46.58% 43.41% -3.18%
+ Complexity 10331 2027 -8304
============================================
Files 2074 404 -1670
Lines 80880 17352 -63528
Branches 9022 2120 -6902
============================================
- Hits 37680 7533 -30147
+ Misses 39728 8984 -30744
+ Partials 3472 835 -2637
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3439?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...gobblin/cluster/ClusterEventMetadataGenerator.java](https://codecov.io/gh/apache/gobblin/pull/3439/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvQ2x1c3RlckV2ZW50TWV0YWRhdGFHZW5lcmF0b3IuamF2YQ==)
| `90.90% <83.33%> (+3.40%)` | :arrow_up: |
|
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/gobblin/pull/3439/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
| `40.00% <0.00%> (-20.00%)` | :arrow_down: |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/gobblin/pull/3439/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `92.85% <0.00%> (-7.15%)` | :arrow_down: |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/gobblin/pull/3439/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `28.26% <0.00%> (-5.08%)` | :arrow_down: |
|
[...blin/service/monitoring/KafkaJobStatusMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3439/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9LYWZrYUpvYlN0YXR1c01vbml0b3IuamF2YQ==)
| | |
|
[.../java/org/apache/gobblin/writer/WriteCallback.java](https://codecov.io/gh/apache/gobblin/pull/3439/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1dyaXRlQ2FsbGJhY2suamF2YQ==)
| | |
|
[...erter/initializer/ConverterInitializerFactory.java](https://codecov.io/gh/apache/gobblin/pull/3439/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9pbml0aWFsaXplci9Db252ZXJ0ZXJJbml0aWFsaXplckZhY3RvcnkuamF2YQ==)
| | |
|
[...rg/apache/gobblin/source/jdbc/OracleExtractor.java](https://codecov.io/gh/apache/gobblin/pull/3439/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9qZGJjL09yYWNsZUV4dHJhY3Rvci5qYXZh)
| | |
|
[.../gobblin/runtime/spec\_catalog/AddSpecResponse.java](https://codecov.io/gh/apache/gobblin/pull/3439/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvc3BlY19jYXRhbG9nL0FkZFNwZWNSZXNwb25zZS5qYXZh)
| | |
|
[...metrics/reporter/util/NoopSchemaVersionWriter.java](https://codecov.io/gh/apache/gobblin/pull/3439/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci91dGlsL05vb3BTY2hlbWFWZXJzaW9uV3JpdGVyLmphdmE=)
| | |
| ... and [1666
more](https://codecov.io/gh/apache/gobblin/pull/3439/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3439?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3439?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[a7df7ca...50c1da1](https://codecov.io/gh/apache/gobblin/pull/3439?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 690370)
Time Spent: 1h 50m (was: 1h 40m)
> GaaS (DagManager) keep retrying a failed job beyond max attempt number
> ----------------------------------------------------------------------
>
> Key: GOBBLIN-1585
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1585
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The issue is that for the same flow execution, we don't receive the event in
> order. if the job fail and we retry, we may receive running event first, and
> then the Orchestrate event which update the current attempts and should retry
> value will be ignored and cause to job to continually try to retrying util
> the running job finished.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
