[
https://issues.apache.org/jira/browse/GOBBLIN-1594?focusedWorklogId=705304&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-705304
]
ASF GitHub Bot logged work on GOBBLIN-1594:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jan/22 22:39
Start Date: 07/Jan/22 22:39
Worklog Time Spent: 10m
Work Description: codecov-commenter edited a comment on pull request
#3449:
URL: https://github.com/apache/gobblin/pull/3449#issuecomment-1007793055
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3449?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3449](https://codecov.io/gh/apache/gobblin/pull/3449?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(181a86f) into
[master](https://codecov.io/gh/apache/gobblin/commit/a512f20deddfdb37cfb15eca1d49e26da7ddc7d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(a512f20) will **increase** coverage by `2.55%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/gobblin/pull/3449?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3449 +/- ##
============================================
+ Coverage 46.60% 49.15% +2.55%
+ Complexity 10341 8873 -1468
============================================
Files 2074 1693 -381
Lines 80952 65403 -15549
Branches 9031 7494 -1537
============================================
- Hits 37729 32150 -5579
+ Misses 39747 30230 -9517
+ Partials 3476 3023 -453
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3449?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...blin/service/modules/orchestration/DagManager.java](https://codecov.io/gh/apache/gobblin/pull/3449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXIuamF2YQ==)
| `71.64% <88.88%> (+0.30%)` | :arrow_up: |
|
[.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/gobblin/pull/3449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh)
| `71.87% <0.00%> (-7.82%)` | :arrow_down: |
|
[...t/version/TimestampedDatasetStateStoreVersion.java](https://codecov.io/gh/apache/gobblin/pull/3449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3ZlcnNpb24vVGltZXN0YW1wZWREYXRhc2V0U3RhdGVTdG9yZVZlcnNpb24uamF2YQ==)
| `27.77% <0.00%> (-5.56%)` | :arrow_down: |
|
[.../src/main/java/org/apache/gobblin/r2/R2Client.java](https://codecov.io/gh/apache/gobblin/pull/3449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taHR0cC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9yMi9SMkNsaWVudC5qYXZh)
| | |
|
[.../apache/gobblin/converter/AvroR2JoinConverter.java](https://codecov.io/gh/apache/gobblin/pull/3449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taHR0cC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jb252ZXJ0ZXIvQXZyb1IySm9pbkNvbnZlcnRlci5qYXZh)
| | |
|
[...ache/gobblin/converter/AsyncHttpJoinConverter.java](https://codecov.io/gh/apache/gobblin/pull/3449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taHR0cC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jb252ZXJ0ZXIvQXN5bmNIdHRwSm9pbkNvbnZlcnRlci5qYXZh)
| | |
|
[.../metrics/kafka/KafkaAvroSchemaRegistryFactory.java](https://codecov.io/gh/apache/gobblin/pull/3449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3Mva2Fma2EvS2Fma2FBdnJvU2NoZW1hUmVnaXN0cnlGYWN0b3J5LmphdmE=)
| | |
|
[...pache/gobblin/compliance/HivePartitionVersion.java](https://codecov.io/gh/apache/gobblin/pull/3449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY29tcGxpYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jb21wbGlhbmNlL0hpdmVQYXJ0aXRpb25WZXJzaW9uLmphdmE=)
| | |
|
[...g/apache/gobblin/compliance/DatasetDescriptor.java](https://codecov.io/gh/apache/gobblin/pull/3449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY29tcGxpYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jb21wbGlhbmNlL0RhdGFzZXREZXNjcmlwdG9yLmphdmE=)
| | |
|
[...n/service/modules/orchestration/SessionHelper.java](https://codecov.io/gh/apache/gobblin/pull/3449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9zZXJ2aWNlL21vZHVsZXMvb3JjaGVzdHJhdGlvbi9TZXNzaW9uSGVscGVyLmphdmE=)
| | |
| ... and [375
more](https://codecov.io/gh/apache/gobblin/pull/3449/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3449?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3449?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[a512f20...181a86f](https://codecov.io/gh/apache/gobblin/pull/3449?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 705304)
Time Spent: 40m (was: 0.5h)
> Add guard against improperly formed gobblin.flow.sla.time in DagManager
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-1594
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1594
> Project: Apache Gobblin
> Issue Type: Task
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently, a poorly formed SLA time (e.g. String instead of Long) will cause
> the DagManagerThread to completely stall and not make any progress. This is a
> short term fix to at least move the DagManager forward if the SLA is not
> properly defined, future fix will be to verify before flow creation
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
