[
https://issues.apache.org/jira/browse/GOBBLIN-1594?focusedWorklogId=705672&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-705672
]
ASF GitHub Bot logged work on GOBBLIN-1594:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jan/22 10:30
Start Date: 08/Jan/22 10:30
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request #3449:
URL: https://github.com/apache/gobblin/pull/3449
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1594
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
Currently, a poorly formed SLA time (e.g. String instead of Long) will cause
the DagManagerThread to completely stall and not make any progress. This is a
short term fix to at least move the DagManager forward if the SLA is not
properly defined, future fix will be to verify before flow creation
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
DagManagerTest
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 705672)
Time Spent: 1h 10m (was: 1h)
> Add guard against improperly formed gobblin.flow.sla.time in DagManager
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-1594
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1594
> Project: Apache Gobblin
> Issue Type: Task
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Currently, a poorly formed SLA time (e.g. String instead of Long) will cause
> the DagManagerThread to completely stall and not make any progress. This is a
> short term fix to at least move the DagManager forward if the SLA is not
> properly defined, future fix will be to verify before flow creation
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
