[
https://issues.apache.org/jira/browse/GOBBLIN-1616?focusedWorklogId=747608&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747608
]
ASF GitHub Bot logged work on GOBBLIN-1616:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/22 04:55
Start Date: 25/Mar/22 04:55
Worklog Time Spent: 10m
Work Description: phet commented on a change in pull request #3486:
URL: https://github.com/apache/gobblin/pull/3486#discussion_r834952987
##########
File path:
gobblin-core/src/main/java/org/apache/gobblin/source/extractor/extract/restapi/RestApiConnector.java
##########
@@ -144,8 +142,8 @@ protected HttpClient getHttpClient() {
.setStatePropertiesPrefix(ConfigurationKeys.SOURCE_CONN_PREFIX)
.configure(this.state)
.createClient();
- if (httpClient instanceof CloseableHttpClient) {
- this.closer.register((CloseableHttpClient)httpClient);
+ if (httpClient instanceof Closeable) {
Review comment:
since the Closer is our only resource management angle, should we log
when not a Closeable, to give some trace before falling through the cracks?
better still would be to wrap within a holder that implements Closeable.
I did observe we still use the non-Closeable, AutoRetryHttpClient in some
circumstances. if that's what we happen to have would the wrapper use its
ClientConnectionManger to manage resources?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 747608)
Time Spent: 2h (was: 1h 50m)
> Make RestApiConnector be able to close the connection finally
> -------------------------------------------------------------
>
> Key: GOBBLIN-1616
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1616
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> In RestApiConnector, we only consume the HttpEntity but not close the
> response, which potentially leave the socket as CLOSE_WAIT status and eat up
> the resources.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
