[
https://issues.apache.org/jira/browse/GOBBLIN-1616?focusedWorklogId=747874&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747874
]
ASF GitHub Bot logged work on GOBBLIN-1616:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/22 17:04
Start Date: 25/Mar/22 17:04
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on a change in pull request #3486:
URL: https://github.com/apache/gobblin/pull/3486#discussion_r835458789
##########
File path:
gobblin-core/src/main/java/org/apache/gobblin/source/extractor/extract/restapi/RestApiConnector.java
##########
@@ -192,8 +190,8 @@ private static boolean hasId(JsonObject json) {
if (httpEntity != null) {
EntityUtils.consume(httpEntity);
}
- if(httpResponse instanceof CloseableHttpResponse) {
- this.closer.register((CloseableHttpResponse)httpResponse);
+ if(httpResponse instanceof Closeable) {
+ this.closer.register((Closeable)httpResponse);
Review comment:
I just want to make sure those lines will be executed no matter what
happens during the execution to avoid any resource leak. Will address the code
format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 747874)
Time Spent: 2h 10m (was: 2h)
> Make RestApiConnector be able to close the connection finally
> -------------------------------------------------------------
>
> Key: GOBBLIN-1616
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1616
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> In RestApiConnector, we only consume the HttpEntity but not close the
> response, which potentially leave the socket as CLOSE_WAIT status and eat up
> the resources.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
