hanghangliu commented on code in PR #3487:
URL: https://github.com/apache/gobblin/pull/3487#discussion_r854806346
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnAutoScalingManager.java:
##########
@@ -260,12 +302,14 @@ void runInternal() {
// adjust the number of target containers based on the configured min
and max container values.
numTargetContainers = Math.max(this.minContainers,
Math.min(this.maxContainers, numTargetContainers));
+ trimContainerSize(numTargetContainers, yarnContainerRequestBundle);
Review Comment:
This is only to ensure the container size is within the range of max and min
container size read from config. Originally the resource requirement was
universal for all containers. Since we have different resource requirement for
different helix tag, I'm not sure there's any better way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
