hanghangliu commented on code in PR #3487: URL: https://github.com/apache/gobblin/pull/3487#discussion_r854807531
########## gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnContainerRequestBundle.java: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.yarn; + +import java.util.HashMap; +import java.util.HashSet; +import java.util.Map; +import java.util.Set; +import lombok.Getter; +import lombok.Setter; +import lombok.extern.slf4j.Slf4j; +import org.apache.hadoop.yarn.api.records.Resource; + +/** + * The class that represents current Yarn container request that will be used by {link @YarnService}. + * Yarn container allocation should associate with helix tag, as workflows can have specific helix tag setup + * and specific resource requirement. + */ +@Slf4j +@Getter +public class YarnContainerRequestBundle { + int totalContainers; + private final Map<String, Integer> helixTagContainerCountMap; + private final Map<String, Resource> helixTagResourceMap; + private final Map<String, Set<String>> resourceHelixTagMap; + + public YarnContainerRequestBundle() { + this.totalContainers = 0; + this.helixTagContainerCountMap = new HashMap<>(); + this.helixTagResourceMap = new HashMap<>(); + this.resourceHelixTagMap = new HashMap<>(); + } + + public void add(String helixTag, int containerCount, Resource resource) { + helixTagContainerCountMap.put(helixTag, helixTagContainerCountMap.getOrDefault(helixTag, 0) + containerCount); + if(!helixTagResourceMap.containsKey(helixTag)) { + helixTagResourceMap.put(helixTag, resource); + } + Set<String> tagSet = resourceHelixTagMap.getOrDefault(resource.toString(), new HashSet<>()); + tagSet.add(helixTag); + resourceHelixTagMap.put(resource.toString(), tagSet); + totalContainers += containerCount; Review Comment: I think that is expected behavior. Say multiple gobblin job run request the same resource requirement and helix tag, multiple add will be called and the totalContainers ned to be incremented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
