[
https://issues.apache.org/jira/browse/GOBBLIN-1633?focusedWorklogId=762488&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-762488
]
ASF GitHub Bot logged work on GOBBLIN-1633:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Apr/22 18:56
Start Date: 26/Apr/22 18:56
Worklog Time Spent: 10m
Work Description: homatthew commented on code in PR #3494:
URL: https://github.com/apache/gobblin/pull/3494#discussion_r859047519
##########
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/verify/CompactionTimeRangeVerifier.java:
##########
@@ -99,7 +99,8 @@ public Result verify(FileSystemDataset dataset) {
if (compactState.contains(CompactionSlaEventHelper.LAST_RUN_START_TIME)
&&
compactState.getPropAsLong(CompactionSlaEventHelper.LAST_RUN_START_TIME)
> latestEligibleCompactTime.getMillis()) {
- log.warn("Last compaction for {} is {}, not before {}",
dataset.datasetRoot(),
+ log.warn("Last compaction for {} is {}, which is not before
latestEligibleCompactTime={}",
Review Comment:
Readability improvement for log line
Issue Time Tracking
-------------------
Worklog Id: (was: 762488)
Time Spent: 20m (was: 10m)
> Fix compaction actions on job failure not retried if compaction succeeds
> ------------------------------------------------------------------------
>
> Key: GOBBLIN-1633
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1633
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-compaction
> Reporter: Matthew Ho
> Assignee: Issac Buenrostro
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> If a compaction job succeeds but fails before hive registration, then the job
> does not re-register hive partition for the effected hour until the
> re-compaction is run.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
