[
https://issues.apache.org/jira/browse/GOBBLIN-1633?focusedWorklogId=762491&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-762491
]
ASF GitHub Bot logged work on GOBBLIN-1633:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Apr/22 19:10
Start Date: 26/Apr/22 19:10
Worklog Time Spent: 10m
Work Description: homatthew commented on code in PR #3494:
URL: https://github.com/apache/gobblin/pull/3494#discussion_r859057458
##########
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/MRCompactionTask.java:
##########
@@ -101,14 +106,19 @@ public void run() {
public void onMRTaskComplete (boolean isSuccess, Throwable throwable) {
if (isSuccess) {
try {
- setCounterInfo(taskContext.getTaskState());
+ TaskState taskState = taskContext.getTaskState();
+ setCounterInfo(taskState);
List<CompactionCompleteAction> actions =
this.suite.getCompactionCompleteActions();
for (CompactionCompleteAction action: actions) {
action.addEventSubmitter(eventSubmitter);
action.onCompactionJobComplete(dataset);
}
submitEvent(CompactionSlaEventHelper.COMPACTION_COMPLETED_EVENT_NAME);
+ if (dataset instanceof FileSystemDataset) {
Review Comment:
We can only check / persist the state for FileSystemDataset based compaction
jobs, so we needs this typecheck here.
The
[CompactionSuiteBaseWithConfigurableCompleteAction.java](https://github.com/apache/gobblin/commit/a77250b057e1ba83531ee0bed6e8302ed6c18510#diff-3befde2a879553d0eb7deb8a0c9b48951dc1c26c6bcf9fe86701bbfaf3c295df)
and
[CompactionSuiteBase.java](https://github.com/apache/gobblin/blob/d9ae5353c74fdcd385835fca9b586b3fdb90971b/gobblin-compaction/src/main/java/org/apache/gobblin/compaction/suite/CompactionSuiteBase.java)
both implement `CompactionSuite<FileSystemDataset>`.
Issue Time Tracking
-------------------
Worklog Id: (was: 762491)
Time Spent: 0.5h (was: 20m)
> Fix compaction actions on job failure not retried if compaction succeeds
> ------------------------------------------------------------------------
>
> Key: GOBBLIN-1633
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1633
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-compaction
> Reporter: Matthew Ho
> Assignee: Issac Buenrostro
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> If a compaction job succeeds but fails before hive registration, then the job
> does not re-register hive partition for the effected hour until the
> re-compaction is run.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
