[
https://issues.apache.org/jira/browse/GOBBLIN-1635?focusedWorklogId=763157&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-763157
]
ASF GitHub Bot logged work on GOBBLIN-1635:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Apr/22 21:14
Start Date: 27/Apr/22 21:14
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3496:
URL: https://github.com/apache/gobblin/pull/3496#issuecomment-1111490308
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3496?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3496](https://codecov.io/gh/apache/gobblin/pull/3496?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(61b491f) into
[master](https://codecov.io/gh/apache/gobblin/commit/8966a11a4cd26f85da295c20906f1f4a0a7236b9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(8966a11) will **decrease** coverage by `3.22%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #3496 +/- ##
============================================
- Coverage 46.69% 43.47% -3.23%
+ Complexity 10400 2038 -8362
============================================
Files 2077 405 -1672
Lines 81158 17435 -63723
Branches 9060 2129 -6931
============================================
- Hits 37897 7579 -30318
+ Misses 39770 9014 -30756
+ Partials 3491 842 -2649
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...g/common/impl/ConfigStoreBackedValueInspector.java](https://codecov.io/gh/apache/gobblin/pull/3496/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb25maWctbWFuYWdlbWVudC9nb2JibGluLWNvbmZpZy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbmZpZy9jb21tb24vaW1wbC9Db25maWdTdG9yZUJhY2tlZFZhbHVlSW5zcGVjdG9yLmphdmE=)
| `72.72% <100.00%> (ø)` | |
|
[.../store/hdfs/SimpleHadoopFilesystemConfigStore.java](https://codecov.io/gh/apache/gobblin/pull/3496/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb25maWctbWFuYWdlbWVudC9nb2JibGluLWNvbmZpZy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbmZpZy9zdG9yZS9oZGZzL1NpbXBsZUhhZG9vcEZpbGVzeXN0ZW1Db25maWdTdG9yZS5qYXZh)
| `66.40% <100.00%> (ø)` | |
|
[...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3496/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh)
| `60.21% <0.00%> (-2.16%)` | :arrow_down: |
|
[...apache/gobblin/runtime/local/LocalJobLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3496/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9jYWwvTG9jYWxKb2JMYXVuY2hlci5qYXZh)
| | |
|
[...e/gobblin/runtime/app/ServiceBasedAppLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3496/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBwL1NlcnZpY2VCYXNlZEFwcExhdW5jaGVyLmphdmE=)
| | |
|
[...bblin/compaction/mapreduce/MRCompactionRunner.java](https://codecov.io/gh/apache/gobblin/pull/3496/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL01SQ29tcGFjdGlvblJ1bm5lci5qYXZh)
| | |
|
[...org/apache/gobblin/service/FlowConfigV2Client.java](https://codecov.io/gh/apache/gobblin/pull/3496/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJDbGllbnQuamF2YQ==)
| | |
|
[...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/gobblin/pull/3496/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh)
| | |
|
[...gobblin/runtime/MysqlDatasetStateStoreFactory.java](https://codecov.io/gh/apache/gobblin/pull/3496/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvTXlzcWxEYXRhc2V0U3RhdGVTdG9yZUZhY3RvcnkuamF2YQ==)
| | |
|
[...util/limiter/stressTest/RandomRuntimeStressor.java](https://codecov.io/gh/apache/gobblin/pull/3496/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9zdHJlc3NUZXN0L1JhbmRvbVJ1bnRpbWVTdHJlc3Nvci5qYXZh)
| | |
| ... and [1666
more](https://codecov.io/gh/apache/gobblin/pull/3496/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3496?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3496?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[8966a11...61b491f](https://codecov.io/gh/apache/gobblin/pull/3496?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Issue Time Tracking
-------------------
Worklog Id: (was: 763157)
Time Spent: 40m (was: 0.5h)
> Avoid loading env configuration when using config store to improve the
> performance
> ----------------------------------------------------------------------------------
>
> Key: GOBBLIN-1635
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1635
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Now, when load config from config store, we use the system env config as the
> fall back, when the number of env config is large, it significantly slow the
> process to load config store. And after verification, we rarely use anything
> in the env config, so this PR is to avoid that fallback
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
