[
https://issues.apache.org/jira/browse/GOBBLIN-1635?focusedWorklogId=763142&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-763142
]
ASF GitHub Bot logged work on GOBBLIN-1635:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Apr/22 20:38
Start Date: 27/Apr/22 20:38
Worklog Time Spent: 10m
Work Description: ZihanLi58 opened a new pull request, #3496:
URL: https://github.com/apache/gobblin/pull/3496
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-1635] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1635
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Now, when load config from config store, we use the system env config as the
fall back, when the number of env config is large, it significantly slow the
process to load config store. And after verification, we rarely use anything in
the env config, so this PR is to avoid that fallback
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
local build and test on prod to make sure env is not loaded now and pipeline
works as expected
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 763142)
Remaining Estimate: 0h
Time Spent: 10m
> Avoid loading env configuration when using config store to improve the
> performance
> ----------------------------------------------------------------------------------
>
> Key: GOBBLIN-1635
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1635
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Now, when load config from config store, we use the system env config as the
> fall back, when the number of env config is large, it significantly slow the
> process to load config store. And after verification, we rarely use anything
> in the env config, so this PR is to avoid that fallback
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
