Will-Lo commented on PR #3495: URL: https://github.com/apache/gobblin/pull/3495#issuecomment-1111559959
> > nice work! > > this seemed an important element (from your PR summary): > > ``` > Additionally, we also do not want to retry if a flow is skipped due to concurrent jobs running at the same time > ``` > > yet I'm having trouble finding anything related to this in the impl. (a comment saying the same at the least...). does it just come down to some `CANCELED` ones not bearing a `isFlowSlaKilled.equals(true)`? In this scenario I'm describing the timing event emitted is SKIPPED, which is emitted from the Orchestrator. Since the dag isn't created I believe a retry would be overriding the check, which is done in the DagManager (which comes after Orchestration). Also it's unlikely that the concurrent flow actually finished by the time the retry is processed anyways, since we do not have waits before retries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
