phet commented on PR #3495: URL: https://github.com/apache/gobblin/pull/3495#issuecomment-1111610946
> Functionally speaking it's just a cancellation event which isn't user initiated that doesn't have the flag that it was killed due to exceeding the start/runtime SLA would it be worth adding a comment when preparing that internal cancellation saying that it won't be retried because it's missing the flag? per our conversation recently about 'semantic naming', we could always consider naming that flag something like: ``` - public static final String IS_FLOW_SLA_KILLED = "isFlowSlaKilled"; + public static final String DOES_CANCELED_FLOW_MERIT_RETRY = "doesCanceledFlowMeritRetry"; ``` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
