[
https://issues.apache.org/jira/browse/GOBBLIN-1691?focusedWorklogId=803801&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-803801
]
ASF GitHub Bot logged work on GOBBLIN-1691:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Aug/22 22:40
Start Date: 25/Aug/22 22:40
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3545:
URL: https://github.com/apache/gobblin/pull/3545#discussion_r955475616
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/InMemoryUserQuotaManagerTest.java:
##########
@@ -29,16 +29,16 @@
import org.testng.annotations.Test;
-public class UserQuotaManagerTest {
+public class InMemoryUserQuotaManagerTest {
- UserQuotaManager _quotaManager;
+ InMemoryUserQuotaManager _quotaManager;
@BeforeClass
public void setUp() {
Config quotaConfig = ConfigFactory.empty()
- .withValue(UserQuotaManager.PER_USER_QUOTA,
ConfigValueFactory.fromAnyRef("user:1,user2:1,user3:1,user6:1"))
- .withValue(UserQuotaManager.PER_FLOWGROUP_QUOTA,
ConfigValueFactory.fromAnyRef("group1:1,group2:2"));
- this._quotaManager = new UserQuotaManager(quotaConfig);
+ .withValue(InMemoryUserQuotaManager.PER_USER_QUOTA,
ConfigValueFactory.fromAnyRef("user:1,user2:1,user3:1,user6:1"))
Review Comment:
no difference, they are the same shared fields. I changed it to
AbstractUserQuotaManager because that's exactly where they are defined.
Issue Time Tracking
-------------------
Worklog Id: (was: 803801)
Time Spent: 1h 20m (was: 1h 10m)
> add a mysql based user quota manager
> ------------------------------------
>
> Key: GOBBLIN-1691
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1691
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> mysql based user quota manager can share the usage data with other instances
> of Gobblin Service
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
