[
https://issues.apache.org/jira/browse/GOBBLIN-1691?focusedWorklogId=803805&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-803805
]
ASF GitHub Bot logged work on GOBBLIN-1691:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Aug/22 23:17
Start Date: 25/Aug/22 23:17
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3545:
URL: https://github.com/apache/gobblin/pull/3545#discussion_r955492336
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/MysqlUserQuotaManagerTest.java:
##########
@@ -125,13 +125,13 @@ public void testConcurrentChanges() throws IOException,
InterruptedException {
thread1.join();
thread2.join();
thread3.join();
- Assert.assertEquals(this.quotaManager.getCount(TEST_NAME,
AbstractUserQuotaManager.CountType.USER_COUNT), 3000);
+ Assert.assertEquals(this.quotaManager.getCount(PROXY_USER,
AbstractUserQuotaManager.CountType.USER_COUNT), 3000);
thread4.start();
thread5.start();
thread6.start();
thread4.join();
thread5.join();
thread6.join();
- Assert.assertEquals(this.quotaManager.getCount(TEST_NAME,
AbstractUserQuotaManager.CountType.USER_COUNT), -1);
+ Assert.assertEquals(this.quotaManager.getCount(PROXY_USER,
AbstractUserQuotaManager.CountType.USER_COUNT), -1);
Review Comment:
question: why this is -1 but not 0? add comment for this?
Issue Time Tracking
-------------------
Worklog Id: (was: 803805)
Time Spent: 1h 40m (was: 1.5h)
> add a mysql based user quota manager
> ------------------------------------
>
> Key: GOBBLIN-1691
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1691
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> mysql based user quota manager can share the usage data with other instances
> of Gobblin Service
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
