homatthew commented on code in PR #3546:
URL: https://github.com/apache/gobblin/pull/3546#discussion_r956236308
##########
gobblin-cluster/src/test/java/org/apache/gobblin/cluster/GobblinHelixJobLauncherTest.java:
##########
@@ -175,7 +171,7 @@ public void run() {
this.thread.start();
}
- private Properties generateJobProperties(Config baseConfig, String
jobNameSuffix, String jobIdSuffix) {
+ static public Properties generateJobProperties(Config baseConfig, String
jobNameSuffix, String jobIdSuffix) {
Review Comment:
You made this `static public` for testing right? If so, nit: you can make it
package private and use also use `visiblefortesting` annotation to make that
clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
