hanghangliu commented on code in PR #3546:
URL: https://github.com/apache/gobblin/pull/3546#discussion_r960095222
##########
gobblin-cluster/src/test/java/org/apache/gobblin/cluster/GobblinHelixJobLauncherTest.java:
##########
@@ -188,7 +184,7 @@ private Properties generateJobProperties(Config baseConfig,
String jobNameSuffix
// expiry time should be more than the time needed for the job to complete
// otherwise JobContext will become null. This is how Helix work flow
works.
-
properties.setProperty(GobblinClusterConfigurationKeys.HELIX_WORKFLOW_EXPIRY_TIME_SECONDS,
"5");
+
properties.setProperty(GobblinClusterConfigurationKeys.HELIX_WORKFLOW_EXPIRY_TIME_SECONDS,
"15");
Review Comment:
As we discussed, current behavior is whenever we call waitToStop, the
workflow goes to stopping state, and
[HelixUtils.waitJobCompletion](https://github.com/apache/gobblin/blob/8c9c8a84ed23c0215c4d80125ac532e97085d76f/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixUtils.java#L278)
will then delete it, so it never really goes to stopped state. To make the
flow more clear, we need a separate PR to do the refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
