ZihanLi58 commented on code in PR #3552:
URL: https://github.com/apache/gobblin/pull/3552#discussion_r966279627
##########
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/orc/OrcKeyDedupReducer.java:
##########
@@ -59,8 +59,14 @@ protected void reduce(OrcKey key, Iterable<OrcValue> values,
Context context)
/* Map from hash of value(Typed in OrcStruct) object to its times of
duplication*/
Map<Integer, Integer> valuesToRetain = new HashMap<>();
int valueHash = 0;
+ int counter = 0;
Review Comment:
This reduce method will be called once for each key, which means if you
define count here, you probably never see the log and it requires 1000 records
for same key which is highly not possible.
You might want to define the count at class level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
