ZihanLi58 commented on code in PR #3552:
URL: https://github.com/apache/gobblin/pull/3552#discussion_r966313979
##########
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/orc/OrcKeyDedupReducer.java:
##########
@@ -61,6 +65,14 @@ protected void reduce(OrcKey key, Iterable<OrcValue> values,
Context context)
int valueHash = 0;
for (OrcValue value : values) {
+ if (recordCounter == 1) {
+ log.info("Reduced first value");
+ }
+ recordCounter++;
+ if (recordCounter % 1000 == 0) {
+ log.info("Reduced %s values for key %s", recordCounter, key);
Review Comment:
(Reduced %s values for key %s", recordCounter, key) -> "(Reduced %s values
till now)" ?
##########
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/orc/OrcKeyDedupReducer.java:
##########
@@ -61,6 +65,14 @@ protected void reduce(OrcKey key, Iterable<OrcValue> values,
Context context)
int valueHash = 0;
for (OrcValue value : values) {
+ if (recordCounter == 1) {
Review Comment:
recordCounter == 0, start to reduce records?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
