[
https://issues.apache.org/jira/browse/GOBBLIN-1707?focusedWorklogId=811761&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-811761
]
ASF GitHub Bot logged work on GOBBLIN-1707:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/22 23:20
Start Date: 23/Sep/22 23:20
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3569:
URL: https://github.com/apache/gobblin/pull/3569#discussion_r979112246
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergCatalogFactory.java:
##########
@@ -18,14 +18,19 @@
package org.apache.gobblin.data.management.copy.iceberg;
import org.apache.hadoop.conf.Configuration;
-import org.apache.iceberg.hive.HiveCatalogs;
+import org.apache.iceberg.hive.HiveCatalog;
+
+import com.google.common.collect.Maps;
/**
* Provides an {@link IcebergCatalog}.
*/
public class IcebergCatalogFactory {
public static IcebergCatalog create(Configuration configuration) {
- return new IcebergHiveCatalog(HiveCatalogs.loadCatalog(configuration));
+ HiveCatalog hcat = new HiveCatalog();
Review Comment:
actually `HiveCatalogs` is deprecated and got removed in iceberg 0.12 (we're
on 0.11 currently). I attempted upgrading beyond 0.11 and found that quite
easy (ITO migrating source code). even though we collectively decided to
remain on 0.11, I left this change in, because it's stated to be a drop-in
replacement, and it will be one less thing to do when we're ready for >0.11
Issue Time Tracking
-------------------
Worklog Id: (was: 811761)
Time Spent: 1h 10m (was: 1h)
> Add Iceberg support to DistCp
> -----------------------------
>
> Key: GOBBLIN-1707
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1707
> Project: Apache Gobblin
> Issue Type: Task
> Components: gobblin-core
> Reporter: Kip Kohn
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Add capability for iceberg copy/replication to distcp. Support incremental
> copy (only of delta changes since last time) in addition to full copy on
> first time.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
