phet commented on code in PR #3759:
URL: https://github.com/apache/gobblin/pull/3759#discussion_r1313511244
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java:
##########
@@ -491,7 +491,7 @@ public void runJob(Properties jobProps, JobListener
jobListener) throws JobExcep
try {
Spec flowSpec =
this.scheduledFlowSpecs.get(jobProps.getProperty(ConfigurationKeys.JOB_NAME_KEY));
String triggerTimestampMillis = jobProps.getProperty(
- ConfigurationKeys.ORCHESTRATOR_TRIGGER_EVENT_TIME_MILLIS_KEY, "0");
+ ConfigurationKeys.ORCHESTRATOR_TRIGGER_EVENT_TIME_MILLIS_KEY, "-1");
Review Comment:
if this should "never happen", maybe a comment just above, expressing that
it should always be set... and if ever not, the orchestrator will fail the flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
