phet commented on code in PR #3759:
URL: https://github.com/apache/gobblin/pull/3759#discussion_r1313518645
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -249,8 +251,8 @@ public void orchestrate(Spec spec, Properties jobProps,
long triggerTimestampMil
// If multi-active scheduler is enabled do not pass onto DagManager,
otherwise scheduler forwards it directly
// Skip flow compilation as well, since we recompile after receiving
event from DagActionStoreChangeMonitor later
if (flowTriggerHandler.isPresent()) {
- // If triggerTimestampMillis is 0, then it was not set by the job
trigger handler, and we cannot handle this event
- if (triggerTimestampMillis == 0L) {
+ // If triggerTimestampMillis is -1, then it was not set by the job
trigger handler, and we cannot handle this event
Review Comment:
delete "-1, then it was "?
and `s/and/then/`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
