Will-Lo opened a new pull request, #3769: URL: https://github.com/apache/gobblin/pull/3769
…n underestimate in memory Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-XXX ### Description - [ ] Here are some details about my PR, including screenshots (if applicable): Fixes a bug that causes the ORC Writer self tune to underestimate the native ORC writer memory, leading to potential OOM issues. This occurs in the scenario where the writer would close before ever tuning itself and measuring the native ORC writer buffer. During close, the native ORC writer would flush itself - emptying its buffers and leading to the memory estimate to be extremely minimal, then record its memory estimate in the saved state if it has not recorded an estimate before. So for datasets that write a small number of records to file it would greatly underestimate the memory within the native ORC writer. ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
