[
https://issues.apache.org/jira/browse/GOBBLIN-1904?focusedWorklogId=880080&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-880080
]
ASF GitHub Bot logged work on GOBBLIN-1904:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/23 02:18
Start Date: 13/Sep/23 02:18
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3768:
URL: https://github.com/apache/gobblin/pull/3768#issuecomment-1716833604
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3768?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#3768](https://app.codecov.io/gh/apache/gobblin/pull/3768?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(5827b85) into
[master](https://app.codecov.io/gh/apache/gobblin/commit/aee82dd2fc6a8153add7c3271705d008b27bd797?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(aee82dd) will **decrease** coverage by `1.26%`.
> The diff coverage is `20.51%`.
```diff
@@ Coverage Diff @@
## master #3768 +/- ##
============================================
- Coverage 47.14% 45.88% -1.26%
+ Complexity 10903 2172 -8731
============================================
Files 2149 416 -1733
Lines 85081 17984 -67097
Branches 9446 2190 -7256
============================================
- Hits 40110 8252 -31858
+ Misses 41322 8852 -32470
+ Partials 3649 880 -2769
```
| [Files
Changed](https://app.codecov.io/gh/apache/gobblin/pull/3768?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...gobblin/salesforce/SalesforceHistogramService.java](https://app.codecov.io/gh/apache/gobblin/pull/3768?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2FsZXNmb3JjZUhpc3RvZ3JhbVNlcnZpY2UuamF2YQ==)
| `4.08% <4.08%> (ø)` | |
|
[...rg/apache/gobblin/salesforce/SalesforceSource.java](https://app.codecov.io/gh/apache/gobblin/pull/3768?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2FsZXNmb3JjZVNvdXJjZS5qYXZh)
| `45.45% <70.00%> (+25.45%)` | :arrow_up: |
|
[.../java/org/apache/gobblin/salesforce/Histogram.java](https://app.codecov.io/gh/apache/gobblin/pull/3768?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvSGlzdG9ncmFtLmphdmE=)
| `71.42% <71.42%> (ø)` | |
|
[.../org/apache/gobblin/salesforce/HistogramGroup.java](https://app.codecov.io/gh/apache/gobblin/pull/3768?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvSGlzdG9ncmFtR3JvdXAuamF2YQ==)
| `75.00% <75.00%> (ø)` | |
... and [1739 files with indirect coverage
changes](https://app.codecov.io/gh/apache/gobblin/pull/3768/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Issue Time Tracking
-------------------
Worklog Id: (was: 880080)
Remaining Estimate: 0h
Time Spent: 10m
> Refactor Salesforce Source to promote testability
> -------------------------------------------------
>
> Key: GOBBLIN-1904
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1904
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Salesforce source is difficult to test due to many internal classes that
> cannot mock inputs and outputs. We should clean this class and use
> composition to promote testability.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
