phet commented on code in PR #3776:
URL: https://github.com/apache/gobblin/pull/3776#discussion_r1326697885
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/FlowTriggerHandler.java:
##########
@@ -313,4 +313,46 @@ protected static long getUTCTimeFromDelayPeriod(long
delayPeriodMillis) {
Date date = Date.from(localDateTime.atZone(ZoneId.of("UTC")).toInstant());
return GobblinServiceJobScheduler.asUTCEpochMillis(date);
}
+
+ /**
+ * Attempts to acquire lease for a given {@link DagTask} through lease
arbitration
+ * @param dagTask for which we want to attempt to acquire a lease
+ * @return true if successfully acquired lease, or else false
Review Comment:
as mentioned already, the `DagTask` must hold on to its specific
`LeaseObtainedStatus`, so returning a boolean thwarts that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
