phet commented on code in PR #3776:
URL: https://github.com/apache/gobblin/pull/3776#discussion_r1326713340
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -136,14 +148,26 @@ protected void processMessage(DecodeableKafkaRecord
message) {
// We only expect INSERT and DELETE operations done to this table. INSERTs
correspond to any type of
// {@link DagActionStore.FlowActionType} flow requests that have to be
processed. DELETEs require no action.
try {
+
if (operation.equals("INSERT")) {
if (dagActionType.equals(DagActionStore.FlowActionType.RESUME)) {
log.info("Received insert dag action and about to send resume flow
request");
dagManager.handleResumeFlowRequest(flowGroup,
flowName,Long.parseLong(flowExecutionId));
+ //TODO: add a flag for if condition only if multi-active is enabled
+ if(isRefactoredDagManagerEnabled) {
+ ResumeDagTask resumeDagTask = new ResumeDagTask(new
DagManager.DagId(flowGroup, flowName, flowExecutionId));
+ dagTaskStream.resumeFlow(resumeDagTask);
+ }
Review Comment:
maybe interpret the flag earlier and turn this into an `Optional` to
simplify control flow with `.ifPresent` (which is part of java, but not guava
`Optional`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
