[
https://issues.apache.org/jira/browse/GOBBLIN-1910?focusedWorklogId=880570&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-880570
]
ASF GitHub Bot logged work on GOBBLIN-1910:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Sep/23 02:56
Start Date: 15/Sep/23 02:56
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3776:
URL: https://github.com/apache/gobblin/pull/3776#discussion_r1326695013
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagTaskVisitor.java:
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.service.modules.orchestration;
+
+import java.io.IOException;
+
+
+/**
+ * Interface defining {@link DagTask} based on the type of visitor.
+ * @param <T>
+ */
+@WorkInProgress
+public interface DagTaskVisitor<T> {
+ T meet(LaunchDagTask launchDagTask)
+ throws IOException, InstantiationException, IllegalAccessException;
+ T meet(KillDagTask killDagTask) throws IOException;
Review Comment:
I had expected them to all have identical exception signatures...
anyway, given that this is a generic (so we can presume nothing about the
return type and hence what it's doing), the only appropriate types of
exceptions are either to declare `throws Exception` or declare nothing and wrap
everything internally by `RuntimeException`
Issue Time Tracking
-------------------
Worklog Id: (was: 880570)
Time Spent: 3h 40m (was: 3.5h)
> Refactor code to move current in-memory references to new design for REST
> calls: Launch, Resume and Kill
> --------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1910
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1910
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
