[jira] [Work logged] (GOBBLIN-1910) Refactor code to move current in-memory references to new design for REST calls: Launch, Resume and Kill

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/GOBBLIN-1910?focusedWorklogId=880572&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-880572
 ]

ASF GitHub Bot logged work on GOBBLIN-1910:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Sep/23 02:58
            Start Date: 15/Sep/23 02:58
    Worklog Time Spent: 10m 
      Work Description: phet commented on code in PR #3776:
URL: https://github.com/apache/gobblin/pull/3776#discussion_r1326697885


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/FlowTriggerHandler.java:
##########
@@ -313,4 +313,46 @@ protected static long getUTCTimeFromDelayPeriod(long 
delayPeriodMillis) {
     Date date = Date.from(localDateTime.atZone(ZoneId.of("UTC")).toInstant());
     return GobblinServiceJobScheduler.asUTCEpochMillis(date);
   }
+
+  /**
+   * Attempts to acquire lease for a given {@link DagTask} through lease 
arbitration
+   * @param dagTask for which we want to attempt to acquire a lease
+   * @return true if successfully acquired lease, or else false

Review Comment:
   as mentioned already, the `DagTask` must hold on to its specific 
`LeaseObtainedStatus`, so returning a boolean thwarts that





Issue Time Tracking
-------------------

    Worklog Id:     (was: 880572)
    Time Spent: 4h  (was: 3h 50m)

> Refactor code to move current in-memory references to new design for REST 
> calls: Launch, Resume and Kill
> --------------------------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1910
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1910
>             Project: Apache Gobblin
>          Issue Type: New Feature
>            Reporter: Meeth Gala
>            Priority: Major
>          Time Spent: 4h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)