[
https://issues.apache.org/jira/browse/GOBBLIN-1910?focusedWorklogId=882014&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882014
]
ASF GitHub Bot logged work on GOBBLIN-1910:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Sep/23 20:14
Start Date: 26/Sep/23 20:14
Worklog Time Spent: 10m
Work Description: meethngala commented on code in PR #3776:
URL: https://github.com/apache/gobblin/pull/3776#discussion_r1337729147
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/FinishResumeDagProc.java:
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gobblin.service.modules.orchestration;
+
+import java.io.IOException;
+import java.util.Map;
+import java.util.concurrent.ExecutionException;
+
+import lombok.extern.slf4j.Slf4j;
+
+import org.apache.gobblin.runtime.api.DagActionStore;
+import org.apache.gobblin.service.modules.flowgraph.Dag;
+import
org.apache.gobblin.service.modules.orchestration.exception.MaybeRetryableException;
+import org.apache.gobblin.service.modules.spec.JobExecutionPlan;
+import org.apache.gobblin.service.monitoring.JobStatus;
+
+import static org.apache.gobblin.service.ExecutionStatus.CANCELLED;
+import static org.apache.gobblin.service.ExecutionStatus.FAILED;
+import static org.apache.gobblin.service.ExecutionStatus.PENDING_RESUME;
+
+
+/**
+ * An implementation of {@link DagProc} that will process {@link DagTask} will
PENDING_RESUME job status.
+ * This can be handled either via {@link AdvanceDagProc} or have a separate
procedure to handle PENDING_RESUME events.
+ * Currently, I have this boilerplate code, but can decide if it makes have a
separate procedure for completion of
+ * PENDING_RESUME events.
+ */
+@WorkInProgress
+@Slf4j
+public class FinishResumeDagProc extends DagProc {
+ private DagManagementStateStore dagManagementStateStore = new
DagManagementStateStore();
+
+ private DagTaskStream dagTaskStream;
+ private DagStateStore dagStateStore;
+ private DagStateStore failedDagStateStore;
+
+ @Override
+ protected Object initialize() {
Review Comment:
agreed... refactored the logic to have `initialize()` capture the state of
the Dag/DagNode on which we need to `act`. Retries have been defined inside
`DagProc` for each of the methods likewise `initialize(), act() and
sendNotification()`
Issue Time Tracking
-------------------
Worklog Id: (was: 882014)
Time Spent: 8h 50m (was: 8h 40m)
> Refactor code to move current in-memory references to new design for REST
> calls: Launch, Resume and Kill
> --------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1910
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1910
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 8h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
