[
https://issues.apache.org/jira/browse/GOBBLIN-1910?focusedWorklogId=882019&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882019
]
ASF GitHub Bot logged work on GOBBLIN-1910:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Sep/23 20:49
Start Date: 26/Sep/23 20:49
Worklog Time Spent: 10m
Work Description: meethngala commented on code in PR #3776:
URL: https://github.com/apache/gobblin/pull/3776#discussion_r1337765475
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagement.java:
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.service.modules.orchestration;
+
+import java.io.IOException;
+import java.util.concurrent.ExecutionException;
+
+import org.apache.gobblin.annotation.Alpha;
+import org.apache.gobblin.service.modules.flowgraph.Dag;
+import org.apache.gobblin.service.modules.spec.JobExecutionPlan;
+import org.apache.gobblin.service.monitoring.JobStatus;
+
+
+/**
+ * Responsible for defining the behavior of {@link DagTask} handling scenarios
for launch, resume, kill, job start
+ * and flow completion deadlines
+ *
+ */
+@Alpha
+public interface DagManagement {
+
+ /**
+ * Currently, it is handling just the launch of a {@link Dag} request via
REST client for adhoc flows
+ * @param flowGroup
+ * @param flowName
+ * @param triggerTimeStamp
+ */
+ void launchFlow(String flowGroup, String flowName, long triggerTimeStamp);
+
+ /**
+ * Currently, it is handling just the resume of a {@link Dag} request via
REST client for adhoc flows
+ * @param flowGroup
+ * @param flowName
+ * @param flowExecutionId
+ * @param triggerTimeStamp
+ * @throws IOException
+ */
+ void resumeFlow(String flowGroup, String flowName, String flowExecutionId,
long triggerTimeStamp)
+ throws IOException, InterruptedException;
+
+ /**
+ * Currently, it is handling just the kill/cancel of a {@link Dag} request
via REST client for adhoc flows
+ * @param flowGroup
+ * @param flowName
+ * @param flowExecutionId
+ * @param triggerTimeStamp
+ */
+ void killFlow(String flowGroup, String flowName, String flowExecutionId,
long triggerTimeStamp)
Review Comment:
gotcha... I'll use `triggerTimestamp` for scheduler and `eventTimestamp` for
REST client requests
Issue Time Tracking
-------------------
Worklog Id: (was: 882019)
Time Spent: 9.5h (was: 9h 20m)
> Refactor code to move current in-memory references to new design for REST
> calls: Launch, Resume and Kill
> --------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1910
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1910
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 9.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
