[
https://issues.apache.org/jira/browse/GOBBLIN-1929?focusedWorklogId=885146&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885146
]
ASF GitHub Bot logged work on GOBBLIN-1929:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Oct/23 23:47
Start Date: 13/Oct/23 23:47
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3799:
URL: https://github.com/apache/gobblin/pull/3799#discussion_r1358961110
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergTable.java:
##########
@@ -202,4 +204,15 @@ protected void registerIcebergTable(TableMetadata
srcMetadata, TableMetadata dst
this.tableOps.commit(dstMetadata,
srcMetadata.replaceProperties(dstMetadata.properties()));
}
}
+
+ /**
+ * Provides absolute path of the iceberg table location
+ * @return string value of table location if present
+ * @throws TableNotFoundException
+ */
+ public String getTablePath() throws TableNotFoundException {
+ Path tablePath = Paths.get(accessTableMetadata().location());
+ log.info("Iceberg table location: {}", tablePath.toAbsolutePath());
Review Comment:
in my opinion, every get call should not log the entity being returned.
setters may log
Issue Time Tracking
-------------------
Worklog Id: (was: 885146)
Time Spent: 20m (was: 10m)
> Implement Dataset Path for IcebergDataset and RecursiveCopyableDataset
> ----------------------------------------------------------------------
>
> Key: GOBBLIN-1929
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1929
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
