[ 
https://issues.apache.org/jira/browse/GOBBLIN-1929?focusedWorklogId=885151&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885151
 ]

ASF GitHub Bot logged work on GOBBLIN-1929:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Oct/23 00:06
            Start Date: 14/Oct/23 00:06
    Worklog Time Spent: 10m 
      Work Description: meethngala commented on code in PR #3799:
URL: https://github.com/apache/gobblin/pull/3799#discussion_r1358986886


##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergTable.java:
##########
@@ -19,6 +19,8 @@
 
 import java.io.IOException;
 import java.net.URI;
+import java.nio.file.Path;

Review Comment:
   nope... I wanted to resolve `Path` to the absolute path which is impl. in 
`java.nio.file.Path`. If we want to use `org.apache.hadoop.fs.Path` I will have 
to use `makeQualified(URI defaultUri, Path workingDir )`. Let me know the 
concern behind not using the current java lib and I can change it





Issue Time Tracking
-------------------

    Worklog Id:     (was: 885151)
    Time Spent: 1h 10m  (was: 1h)

> Implement Dataset Path for IcebergDataset and RecursiveCopyableDataset
> ----------------------------------------------------------------------
>
>                 Key: GOBBLIN-1929
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1929
>             Project: Apache Gobblin
>          Issue Type: New Feature
>            Reporter: Meeth Gala
>            Priority: Major
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to