[
https://issues.apache.org/jira/browse/GOBBLIN-1910?focusedWorklogId=904673&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-904673
]
ASF GitHub Bot logged work on GOBBLIN-1910:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Feb/24 00:04
Start Date: 13/Feb/24 00:04
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3858:
URL: https://github.com/apache/gobblin/pull/3858#discussion_r1486958052
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/LaunchDagProc.java:
##########
@@ -0,0 +1,205 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.service.modules.orchestration.proc;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.Future;
+
+import com.google.common.base.Optional;
+import com.google.common.collect.Maps;
+
+import lombok.extern.slf4j.Slf4j;
+
+import org.apache.gobblin.annotation.Alpha;
+import org.apache.gobblin.metrics.event.TimingEvent;
+import org.apache.gobblin.runtime.api.JobSpec;
+import org.apache.gobblin.runtime.api.Spec;
+import org.apache.gobblin.runtime.api.SpecProducer;
+import org.apache.gobblin.service.ExecutionStatus;
+import org.apache.gobblin.service.FlowId;
+import org.apache.gobblin.service.modules.flowgraph.Dag;
+import
org.apache.gobblin.service.modules.orchestration.DagManagementStateStore;
+import org.apache.gobblin.service.modules.orchestration.DagManager;
+import org.apache.gobblin.service.modules.orchestration.DagManagerUtils;
+import org.apache.gobblin.service.modules.orchestration.NewDagManager;
+import org.apache.gobblin.service.modules.orchestration.TimingEventUtils;
+import org.apache.gobblin.service.modules.orchestration.task.LaunchDagTask;
+import org.apache.gobblin.service.modules.spec.JobExecutionPlan;
+
+
+/**
+ * An implementation of {@link DagProc} for launching {@link
org.apache.gobblin.service.modules.orchestration.task.DagTask}.
+ */
+@Slf4j
+@Alpha
+public class LaunchDagProc extends DagProc<Dag<JobExecutionPlan>, Void> {
+ private final LaunchDagTask launchDagTask;
+ NewDagManager newDagManager;
+
+ public LaunchDagProc(LaunchDagTask launchDagTask, NewDagManager
newDagManager) {
+ this.launchDagTask = launchDagTask;
+ this.newDagManager = newDagManager;
+ }
+
+ @Override
+ protected Dag<JobExecutionPlan> initialize(DagManagementStateStore
dagManagementStateStore) throws IOException {
+ return
dagManagementStateStore.getDag(this.launchDagTask.getDagId().toString());
+ }
+
+ @Override
+ protected Void act(DagManagementStateStore dagManagementStateStore,
Dag<JobExecutionPlan> dag) throws IOException {
+ if (dag == null) {
+ log.warn("No dag with id " + this.launchDagTask.getDagId() + " found to
launch");
+ return null;
+ }
+ initializeDag(dag, dagManagementStateStore);
+ DagManagerUtils.submitPendingExecStatus(dag, this.eventSubmitter);
+ return null;
+ }
+
+ protected void initializeDag(Dag<JobExecutionPlan> dag,
DagManagementStateStore dagManagementStateStore)
+ throws IOException {
+ //Add Dag to the map of running dags
+ String dagId = DagManagerUtils.generateDagId(dag).toString();
+ log.info("Initializing Dag {}",
DagManagerUtils.getFullyQualifiedDagName(dag));
+
+ //A flag to indicate if the flow is already running.
+ boolean isDagRunning = false;
+ //Are there any jobs already in the running state? This check is for Dags
already running
+ //before a leadership change occurs.
+ for (Dag.DagNode<JobExecutionPlan> dagNode : dag.getNodes()) {
+ if (DagManagerUtils.getExecutionStatus(dagNode) ==
ExecutionStatus.RUNNING) {
+ dagManagementStateStore.addJobState(dagId, dagNode);
+ //Update the running jobs counter.
+
NewDagManager.getDagManagerMetrics().incrementRunningJobMetrics(dagNode);
Review Comment:
good idea. will move it there in the next PR.
Issue Time Tracking
-------------------
Worklog Id: (was: 904673)
Time Spent: 21h 40m (was: 21.5h)
> Refactor code to move current in-memory references to new design for REST
> calls: Launch, Resume and Kill
> --------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1910
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1910
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 21h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
