[
https://issues.apache.org/jira/browse/GOBBLIN-1910?focusedWorklogId=906724&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-906724
]
ASF GitHub Bot logged work on GOBBLIN-1910:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Feb/24 23:42
Start Date: 23/Feb/24 23:42
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3858:
URL: https://github.com/apache/gobblin/pull/3858#discussion_r1501208594
##########
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java:
##########
@@ -124,6 +126,9 @@ public class ConfigurationKeys {
public static final String SCHEDULER_MAX_BACKOFF_MILLIS_KEY =
MYSQL_LEASE_ARBITER_PREFIX + ".maxBackoffMillis";
public static final int DEFAULT_SCHEDULER_MAX_BACKOFF_MILLIS = 10000;
+ public static final String GOBBLIN_SERVICE_DAG_PROCESSING_ENGINE_PREFIX =
ServiceConfigKeys.GOBBLIN_SERVICE_PREFIX + "dagProcessingEngine.";
+ public static final String DAG_PROCESSING_ENGINE_ENABLED =
GOBBLIN_SERVICE_DAG_PROCESSING_ENGINE_PREFIX + "enabled";
Review Comment:
apologies if I was confused and earlier suggested to move this from
`ServiceConfigKeys` (I forget details...)
anyway given that `ConfigurationKeys` would now need to reference SCKs, I
see it making the most sense to situate these new ones along w/ their prefix so
all are in SCKs
Issue Time Tracking
-------------------
Worklog Id: (was: 906724)
Time Spent: 22h 50m (was: 22h 40m)
> Refactor code to move current in-memory references to new design for REST
> calls: Launch, Resume and Kill
> --------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1910
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1910
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 22h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
