[
https://issues.apache.org/jira/browse/GOBBLIN-2010?focusedWorklogId=907849&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-907849
]
ASF GitHub Bot logged work on GOBBLIN-2010:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/24 19:44
Start Date: 01/Mar/24 19:44
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3886:
URL: https://github.com/apache/gobblin/pull/3886#discussion_r1509459052
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/activity/impl/ProcessWorkUnitImpl.java:
##########
@@ -62,11 +61,14 @@
public class ProcessWorkUnitImpl implements ProcessWorkUnit {
private static final int LOG_EXTENDED_PROPS_EVERY_WORK_UNITS_STRIDE = 100;
+ private static final String MAX_SOURCE_PATHS_TO_LOG_PER_MULTI_WORK_UNIT =
ProcessWorkUnitImpl.class.getName() + ".maxSourcePathsToLogPerMultiWorkUnit";
+ private static final int DEFAULT_MAX_SOURCE_PATHS_TO_LOG_PER_MULTI_WORK_UNIT
= 5;
+
@Override
public int processWorkUnit(WorkUnitClaimCheck wu) {
try (FileSystem fs = Help.loadFileSystemForce(wu)) {
List<WorkUnit> workUnits = loadFlattenedWorkUnits(wu, fs);
- log.info("WU [{}] - loaded {} workUnits", wu.getCorrelator(),
workUnits.size());
+ log.info("(M)WU [{}] - loaded; found {} workUnits", wu.getCorrelator(),
workUnits.size());
Review Comment:
exactly, hence I put "(M)WU" to cover the case equally of "MWU" or "WU".
would you prefer I write it as:
```
log.info("WU/MWU [{}] - loaded; found {} workUnits", ...);
```
?
Issue Time Tracking
-------------------
Worklog Id: (was: 907849)
Remaining Estimate: 0h
Time Spent: 10m
> Implement Gobblin-on-Temporal End-to-End Workflow
> -------------------------------------------------
>
> Key: GOBBLIN-2010
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2010
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-core
> Reporter: Kip Kohn
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Provide a complete capability to execute a full Gobblin job through
> Temporal.io. This follows on
> https://issues.apache.org/jira/browse/GOBBLIN-1945 and
> https://issues.apache.org/jira/browse/GOBBLIN-2007 . Thereafter it will be
> possible to provide an arbitrary `JobState` config that specifies the
> intended `Source`, `Writer`, Publisher`, `Converter` etc. in order to carry
> out whatever Data Movement is desired.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
