arjun4084346 commented on code in PR #3899: URL: https://github.com/apache/gobblin/pull/3899#discussion_r1533898669
########## gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/FlowLaunchMultiActiveLeaseArbiterFactory.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.runtime.api; + +import java.io.IOException; +import java.util.Objects; + +import com.typesafe.config.Config; + +import javax.inject.Inject; +import javax.inject.Provider; +import lombok.extern.slf4j.Slf4j; + +import org.apache.gobblin.configuration.ConfigurationKeys; + + +/** + * A factory implementation that returns a {@link InstrumentedLeaseArbiter} instance used by the + * {@link FlowLaunchHandler} in multi-active scheduler mode + */ +@Slf4j +public class FlowLaunchMultiActiveLeaseArbiterFactory implements Provider<InstrumentedLeaseArbiter> { + private final Config config; + + @Inject + public FlowLaunchMultiActiveLeaseArbiterFactory(Config config) { + this.config = Objects.requireNonNull(config); + } + + private InstrumentedLeaseArbiter createFlowLaunchLeaseArbiter() + throws ReflectiveOperationException, IOException { + Config flowLaunchLeaseArbiterConfig = this.config.getConfig(ConfigurationKeys.SCHEDULER_LEASE_ARBITER_NAME); + log.info("FlowLaunchHandler lease arbiter will be initialized with config {}", flowLaunchLeaseArbiterConfig); + + return new InstrumentedLeaseArbiter(config, new MysqlMultiActiveLeaseArbiter(flowLaunchLeaseArbiterConfig), + ConfigurationKeys.SCHEDULER_LEASE_ARBITER_NAME); + } + + @Override + public InstrumentedLeaseArbiter get() { + try { + InstrumentedLeaseArbiter leaseArbiter = createFlowLaunchLeaseArbiter(); Review Comment: why not just move the content of `createFlowLaunchLeaseArbiter` here. It is a one line method and `createFlowLaunchLeaseArbiter` is private so has no other use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
