phet commented on code in PR #3899:
URL: https://github.com/apache/gobblin/pull/3899#discussion_r1538661690
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DagProc.java:
##########
@@ -36,6 +37,7 @@
* actions based on the type of {@link DagTask} and finally submitting an
event to the executor.
*/
@Alpha
+@RequiredArgsConstructor
Review Comment:
I don't see any required args... do you have one you still plan to add?
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DagProc.java:
##########
@@ -59,7 +61,5 @@ public final void process(DagManagementStateStore
dagManagementStateStore) throw
protected abstract void sendNotification(T result, EventSubmitter
eventSubmitter) throws IOException;
// todo - commit the modified dags to the persistent store, maybe not
required for InMem dagManagementStateStore
- protected void commit(DagManagementStateStore dagManagementStateStore, T
result) {
-
- }
+ protected abstract void commit(DagManagementStateStore
dagManagementStateStore, T result);
Review Comment:
why no base class impl?
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/LaunchDagProc.java:
##########
@@ -192,6 +193,15 @@ private void submitJobToExecutor(DagManagementStateStore
dagManagementStateStore
}
}
+ @Override
protected void sendNotification(Optional<Dag<JobExecutionPlan>> result,
EventSubmitter eventSubmitter) {
}
+
+ @Override
+ protected void commit(DagManagementStateStore dagManagementStateStore,
Optional<Dag<JobExecutionPlan>> result) {
+ // Only call conclude method if multi-active execution enabled
+ if (this.isMultiActiveExecutionEnabled) {
+ this.launchDagTask.conclude();
+ }
+ }
Review Comment:
let's try to have the base class implement, by adding members:
```
private DagTask dagTask;
private boolean isMAExecEnabled;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
