[
https://issues.apache.org/jira/browse/GOBBLIN-2020?focusedWorklogId=910951&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910951
]
ASF GitHub Bot logged work on GOBBLIN-2020:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/24 19:20
Start Date: 21/Mar/24 19:20
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #3900:
URL: https://github.com/apache/gobblin/pull/3900
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2020
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
There are a few bugs in Gobblin-Temporal execution mode:
1. If the publishing step fails, the activity does not report a failure due
to missing a step post commit to check the dataset states
2. No GTEs are emitted upon job failure, which makes tracking difficult
3. Some metadata propagation for flow execution ID with workflows is
incorrect due to a bug reading worker configs instead of job props
4. The GenerateWus activity does not return the right number of workunits
created due to counting top level multiworkunits
This PR addresses the above 4 issues and resolves them
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Confirmed that flows can actually fail due to failed commits, number of
tasks processed by workunit generation and task processing is matching,
concurrent flows will read from job Props and not worker configs which lead to
duplicate workflow name conflicts.
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 910951)
Remaining Estimate: 0h
Time Spent: 10m
> Fixes failed workflow paths in Temporal to properly emit GTE and fail job
> when commit fails
> -------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2020
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2020
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There are a few bugs in Gobblin-Temporal execution mode:
> 1. If the publishing step fails, the activity does not report a failure due
> to missing a step post commit to check the dataset states
> 2. No GTEs are emitted upon job failure, which makes tracking difficult
> 3. Some metadata propagation for flow execution ID with workflows is
> incorrect due to a bug reading worker configs instead of job props
> 4. The GenerateWus activity does not return the right number of workunits
> created due to counting top level multiworkunits
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
