[
https://issues.apache.org/jira/browse/GOBBLIN-2020?focusedWorklogId=910955&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910955
]
ASF GitHub Bot logged work on GOBBLIN-2020:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/24 19:36
Start Date: 21/Mar/24 19:36
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3900:
URL: https://github.com/apache/gobblin/pull/3900#issuecomment-2013488782
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3900?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
Attention: Patch coverage is `0%` with `33 lines` in your changes are
missing coverage. Please review.
> Project coverage is 47.44%. Comparing base
[(`058d23d`)](https://app.codecov.io/gh/apache/gobblin/commit/058d23de7a3df4caf6750144f418f29366faf56c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`d0ec600`)](https://app.codecov.io/gh/apache/gobblin/pull/3900?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
|
[Files](https://app.codecov.io/gh/apache/gobblin/pull/3900?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[.../ddm/workflow/impl/ExecuteGobblinWorkflowImpl.java](https://app.codecov.io/gh/apache/gobblin/pull/3900?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC9kZG0vd29ya2Zsb3cvaW1wbC9FeGVjdXRlR29iYmxpbldvcmtmbG93SW1wbC5qYXZh)
| 0.00% | [23 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3900?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...temporal/ddm/activity/impl/CommitActivityImpl.java](https://app.codecov.io/gh/apache/gobblin/pull/3900?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC9kZG0vYWN0aXZpdHkvaW1wbC9Db21taXRBY3Rpdml0eUltcGwuamF2YQ==)
| 0.00% | [7 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3900?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...che/gobblin/temporal/ddm/work/assistance/Help.java](https://app.codecov.io/gh/apache/gobblin/pull/3900?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC9kZG0vd29yay9hc3Npc3RhbmNlL0hlbHAuamF2YQ==)
| 0.00% | [2 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3900?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...poral/ddm/activity/impl/GenerateWorkUnitsImpl.java](https://app.codecov.io/gh/apache/gobblin/pull/3900?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC9kZG0vYWN0aXZpdHkvaW1wbC9HZW5lcmF0ZVdvcmtVbml0c0ltcGwuamF2YQ==)
| 0.00% | [1 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3900?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3900 +/- ##
============================================
- Coverage 48.19% 47.44% -0.75%
+ Complexity 9024 8145 -879
============================================
Files 1765 1553 -212
Lines 68165 61604 -6561
Branches 7336 6989 -347
============================================
- Hits 32851 29227 -3624
+ Misses 32485 29672 -2813
+ Partials 2829 2705 -124
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3900?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 910955)
Time Spent: 40m (was: 0.5h)
> Fixes failed workflow paths in Temporal to properly emit GTE and fail job
> when commit fails
> -------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2020
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2020
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> There are a few bugs in Gobblin-Temporal execution mode:
> 1. If the publishing step fails, the activity does not report a failure due
> to missing a step post commit to check the dataset states
> 2. No GTEs are emitted upon job failure, which makes tracking difficult
> 3. Some metadata propagation for flow execution ID with workflows is
> incorrect due to a bug reading worker configs instead of job props
> 4. The GenerateWus activity does not return the right number of workunits
> created due to counting top level multiworkunits
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
