[
https://issues.apache.org/jira/browse/GOBBLIN-2020?focusedWorklogId=911341&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911341
]
ASF GitHub Bot logged work on GOBBLIN-2020:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/24 17:27
Start Date: 25/Mar/24 17:27
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3900:
URL: https://github.com/apache/gobblin/pull/3900#discussion_r1537939847
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/activity/impl/GenerateWorkUnitsImpl.java:
##########
@@ -75,7 +75,7 @@ public int generateWorkUnits(Properties jobProps,
EventSubmitterContext eventSub
JobStateUtils.writeWorkUnits(workUnits, workDirRoot, jobState, fs);
JobStateUtils.writeJobState(jobState, workDirRoot, fs);
- return workUnits.size();
+ return jobState.getTaskCount();
Review Comment:
since I got it wrong the first time, this likely deserves a comment.
also, I may have forgotten to log the count anywhere, yet it could be
meaningful to log both the MWUs and WUs/tasks count. (doing so might even do
double duty-duty in lieu of that comment I just suggested)
Issue Time Tracking
-------------------
Worklog Id: (was: 911341)
Time Spent: 2h (was: 1h 50m)
> Fixes failed workflow paths in Temporal to properly emit GTE and fail job
> when commit fails
> -------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2020
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2020
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> There are a few bugs in Gobblin-Temporal execution mode:
> 1. If the publishing step fails, the activity does not report a failure due
> to missing a step post commit to check the dataset states
> 2. No GTEs are emitted upon job failure, which makes tracking difficult
> 3. Some metadata propagation for flow execution ID with workflows is
> incorrect due to a bug reading worker configs instead of job props
> 4. The GenerateWus activity does not return the right number of workunits
> created due to counting top level multiworkunits
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
