phet commented on code in PR #3896:
URL: https://github.com/apache/gobblin/pull/3896#discussion_r1538580827
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DagProc.java:
##########
@@ -46,18 +50,21 @@ public final void process(DagManagementStateStore
dagManagementStateStore) throw
S state = initialize(dagManagementStateStore); // todo - retry
T result = act(dagManagementStateStore, state); // todo - retry
commit(dagManagementStateStore, result); // todo - retry
- sendNotification(result, eventSubmitter); // todo - retry
log.info("{} successfully concluded actions for dagId : {}",
getClass().getSimpleName(), getDagId());
}
- protected abstract DagManager.DagId getDagId();
+ protected DagManager.DagId getDagId() {
+ return this.dagTask.getDagId();
+ }
+
+ protected DagNodeId getDagNodeId() {
+ return this.dagTask.getDagNodeId();
+ }
protected abstract S initialize(DagManagementStateStore
dagManagementStateStore) throws IOException;
protected abstract T act(DagManagementStateStore dagManagementStateStore, S
state) throws IOException;
- protected abstract void sendNotification(T result, EventSubmitter
eventSubmitter) throws IOException;
Review Comment:
[if this really is
critical](https://github.com/apache/gobblin/pull/3896#discussion_r1538469764),
let's document in code via a comment.
in addition, if we decide there's little value in the sequence `init -> act
-> sendNotification`, then there's likely no need for the generic param `T`
(thus: `void act(DMSS dmss, S state) throws IOE`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
