phet commented on code in PR #3896:
URL: https://github.com/apache/gobblin/pull/3896#discussion_r1538627514
##########
gobblin-service/src/test/java/org/apache/gobblin/service/monitoring/FsJobStatusRetrieverTest.java:
##########
@@ -47,6 +50,8 @@ public void setUp() throws Exception {
.withValue(FsJobStatusRetriever.CONF_PREFIX + "." +
ConfigurationKeys.STATE_STORE_ROOT_DIR_KEY,
ConfigValueFactory.fromAnyRef(stateStoreDir));
this.jobStatusRetriever = new FsJobStatusRetriever(config,
mock(MultiContextIssueRepository.class));
+ this.mysqlDagActionStore = mock(MysqlDagActionStore.class);
+ doNothing().when(this.mysqlDagActionStore).addDagAction(any(), any(),
any(), any());
Review Comment:
from looking at this PR's diff, I can't see why this is necessary. (I also
wouldn't expect to see a mysql store being necessary for a FS retriever test.)
these are strong indications that it deserves a source comment, if not
reworking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
