phet commented on code in PR #3899:
URL: https://github.com/apache/gobblin/pull/3899#discussion_r1540605070
##########
gobblin-service/src/test/java/org/apache/gobblin/service/GobblinServiceManagerTest.java:
##########
@@ -266,6 +277,16 @@ public void cleanUp() throws Exception {
mysql.stop();
}
+ /**
+ * Tests retrieving two classes initiated by GobblinServiceGuiceModule. One
is explicitly bound and another optionally
+ * through a configuration enabled in the setup method above.
+ */
+ @Test
+ public void testGetClass() {
+ Assert.assertTrue(this.gobblinServiceManager.getClass(DagManager.class)
instanceof DagManager);
Review Comment:
nit: given we anticipate soon deprecating`DagManager`, is there another
class you could use for this test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
