umustafi commented on code in PR #3899:
URL: https://github.com/apache/gobblin/pull/3899#discussion_r1540282278
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DagProc.java:
##########
@@ -59,7 +61,5 @@ public final void process(DagManagementStateStore
dagManagementStateStore) throw
protected abstract void sendNotification(T result, EventSubmitter
eventSubmitter) throws IOException;
// todo - commit the modified dags to the persistent store, maybe not
required for InMem dagManagementStateStore
- protected void commit(DagManagementStateStore dagManagementStateStore, T
result) {
-
- }
+ protected abstract void commit(DagManagementStateStore
dagManagementStateStore, T result);
Review Comment:
there's no task obj in the base class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
