arjun4084346 commented on code in PR #3904:
URL: https://github.com/apache/gobblin/pull/3904#discussion_r1542093336
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImpl.java:
##########
@@ -93,22 +91,22 @@ public DagTask next() {
throw new RuntimeException("DagManagement not initialized in
multi-active execution mode when required.");
}
try {
- MultiActiveLeaseArbiter.LeaseAttemptStatus leaseAttemptStatus = null;
+ LeaseAttemptStatus leaseAttemptStatus = null;
Review Comment:
The only motivation was that there were too many (inner) classes in one
file, total 4.
and to access LeaseObtainedStatus, one would have to write
`MultiActiveLeaseArbiter.LeaseObtainedStatus` while imo
`LeaseAttemptStatus.LeaseObtainedStatus` makes more sense, because it is closer
to `LeaseObtainedStatus` than to `MultiActiveLeaseArbiter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
